Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ballerina metrics logs observer #43615

Merged

Conversation

NipunaMadhushan
Copy link
Contributor

Purpose

We are implementing log based metrics for Ballerina as a requirement for all WSO2 on-prem and SaaS products that need to use the same stack for observability. In order to retrieve metrics data using OpenSearch, we need to provide log based metrics which contain a format as follows.

[Time Stamp] protocol:<protocol_type> tagKey1:tagValue1 tagKey2:tagValue2 .. response_time:<value_in_seconds>

Fixes #43614

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.42%. Comparing base (fb27ea2) to head (70ee310).
Report is 152 commits behind head on master.

Files with missing lines Patch % Lines
.../ballerina/runtime/observability/ObserveUtils.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43615      +/-   ##
============================================
- Coverage     77.47%   77.42%   -0.06%     
- Complexity    58512    58576      +64     
============================================
  Files          3434     3443       +9     
  Lines        218711   218978     +267     
  Branches      28918    28957      +39     
============================================
+ Hits         169443   169536      +93     
- Misses        39874    40023     +149     
- Partials       9394     9419      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NipunaMadhushan NipunaMadhushan changed the base branch from master to 2201.11.0-stage November 21, 2024 08:58
@NipunaMadhushan NipunaMadhushan changed the base branch from 2201.11.0-stage to master November 28, 2024 04:52
@NipunaMadhushan NipunaMadhushan merged commit 53f6d83 into ballerina-platform:master Dec 19, 2024
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Log metrics for each response
3 participants